-
Notifications
You must be signed in to change notification settings - Fork 63
LW-11005 Governance action proposals projection #1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
d22d1f9 to
b00ee5f
Compare
ginnun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left two minor comments. Once replied, I am OK without even any changes.
packages/projection-typeorm/test/operators/storeGovernanceAction.test.ts
Show resolved
Hide resolved
b00ee5f to
746af31
Compare
rhyslbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the PR title needing to be refined to just limit this to governance protocol params, or are you intending to add more functionality?
packages/projection-typeorm/src/operators/storeGovernanceAction.ts
Outdated
Show resolved
Hide resolved
packages/cardano-services/src/Projection/prepareTypeormProjection.ts
Outdated
Show resolved
Hide resolved
packages/cardano-services/src/Projection/prepareTypeormProjection.ts
Outdated
Show resolved
Hide resolved
It was just a refuse from the past. Refined. |
packages/projection-typeorm/src/entity/GovernanceAction.entity.ts
Outdated
Show resolved
Hide resolved
| rewardAccount?: Cardano.RewardAccount; | ||
|
|
||
| @Column('varchar') | ||
| anchorUrl?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a worker job to fetch those? Is there a ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought for a while to the ticket to open but I wasn't able neither to choose if we need a ticket for the implementation or ATM a spike...
I propose to have first at least some discussions in one of our DS to check which targets we want to achieve and / or what we need.
packages/projection-typeorm/src/entity/GovernanceAction.entity.ts
Outdated
Show resolved
Hide resolved
packages/projection-typeorm/src/operators/storeGovernanceAction.ts
Outdated
Show resolved
Hide resolved
packages/projection-typeorm/test/operators/storeGovernanceAction.test.ts
Show resolved
Hide resolved
mkazlauskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
rhyslbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @iccicci 🎉🔥
770fd09 to
e4349d0
Compare
ginnun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Context
With the need to add projection for protocol parameters update in Conway era, we need to add the governance action proposals projection.
Proposed Solution
Added the projector operator.
Important Changes Introduced
Added the skeleton of transactions projections to docker compose infra.